Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recruitment banner #2931

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add recruitment banner #2931

merged 1 commit into from
Sep 27, 2023

Conversation

catalinailie
Copy link
Contributor

@catalinailie catalinailie commented Sep 20, 2023 •
edited
Loading

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 20, 2023 13:25 Inactive
@catalinailie catalinailie force-pushed the add-user-research-banner branch from 09cccd2 to 2d5ade0 Compare September 25, 2023 14:08
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 25, 2023 14:08 Inactive
@catalinailie catalinailie force-pushed the add-user-research-banner branch from 2d5ade0 to cabff96 Compare September 26, 2023 08:04
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 26, 2023 08:04 Inactive
@catalinailie catalinailie force-pushed the add-user-research-banner branch from cabff96 to 5ee7c09 Compare September 26, 2023 08:04
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 26, 2023 08:05 Inactive
@catalinailie catalinailie force-pushed the add-user-research-banner branch from 5ee7c09 to d3f462b Compare September 26, 2023 08:14
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 26, 2023 08:14 Inactive
@catalinailie catalinailie force-pushed the add-user-research-banner branch from d3f462b to 5b307a6 Compare September 26, 2023 08:21
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 26, 2023 08:22 Inactive
@catalinailie catalinailie marked this pull request as ready for review September 26, 2023 08:33
leenagupte
leenagupte approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MartinJJones
MartinJJones reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment on how we can remove the custom intervention component stylesheet.

app/views/layouts/application.html.erb Outdated Show resolved Hide resolved
app/assets/stylesheets/application.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/components/_intervention.scss Outdated Show resolved Hide resolved
@catalinailie catalinailie force-pushed the add-user-research-banner branch from 5b307a6 to 56bc4d3 Compare September 27, 2023 07:13
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 27, 2023 07:14 Inactive
MartinJJones
MartinJJones reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small request to remove the intervention banner below the breadcrumbs, it should then be good to go 👍

app/views/layouts/application.html.erb Show resolved Hide resolved
@catalinailie catalinailie force-pushed the add-user-research-banner branch from 56bc4d3 to de8a1fd Compare September 27, 2023 08:25
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2931 September 27, 2023 08:25 Inactive
@catalinailie catalinailie merged commit 041671b into main Sep 27, 2023
6 checks passed
@catalinailie catalinailie deleted the add-user-research-banner branch September 27, 2023 10:01
@patrickpatrickpatrick patrickpatrickpatrick mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinJJones MartinJJones MartinJJones approved these changes

@leenagupte leenagupte leenagupte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catalinailie @leenagupte @MartinJJones @govuk-ci