Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking for email subscriptions completion #2900

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Aug 17, 2023

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Adds GA4 tracking for notifications about subscribing/unsubscribing to emails about some pages, specifically:

These events are generated using the auto tracker, with attributes in the notification, so it should only fire when the notification is visible.

Detailed guide with the notification looks like this:

Screenshot 2023-08-17 at 09 27 01

Why

Part of the GA4 migration.

Visual changes

None.

Trello card: https://trello.com/c/TXQOqtZ0/628-email-subscriptions-manage-subscriptions-sign-in-change-unsubscribe-forms

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2900 August 17, 2023 08:31 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2900 August 17, 2023 08:52 Inactive
@andysellick andysellick changed the title Add tracking for email subscriptions Add tracking for email subscriptions completion Aug 17, 2023
@andysellick andysellick marked this pull request as ready for review August 17, 2023 08:59
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Hopefully this isn't too much of a headache, but it looks like some of the text used might get translated so I've requested changes in case this can be resolved. Thanks

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2900 August 21, 2023 07:42 Inactive
- adds GA4 tracking for notifications about subscribing/unsubscribing to emails about some pages, specifically detailed guides, calls for evidence, consultations, publications
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2900 August 21, 2023 07:50 Inactive
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@andysellick andysellick merged commit 1030b26 into main Aug 21, 2023
@andysellick andysellick deleted the track-subscriptions branch August 21, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants