Add spacing to WorldWideOrganisation descriptions #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
fix-spacing-issue-on-roles-on-worldwide-organisation
branch
from
cc4b2b4 to
9abc17f
Compare
Fixes an issue where the description of people that was being generated by the WorldWideOrganisationPresenter was not adding spacing between multiple roles. Fixed the issue and added test cases.
patrickpatrickpatrick
force-pushed
the
fix-spacing-issue-on-roles-on-worldwide-organisation
branch
from
9abc17f to
806863a
Compare
patrickpatrickpatrick
deleted the
fix-spacing-issue-on-roles-on-worldwide-organisation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds ", " to a join on the roles of a person in the WorldWideOrganisationPresenter. Adds test cases for spaces being present between roles in the description.
Why
Fixes an issue where the description of people that was being generated by the WorldWideOrganisationPresenter was not adding spacing between multiple roles. Issue raised in a ticket on Zendesk.
Visual Differences
Before
After
Follow these steps if you are doing a Rails upgrade.