Remove banner from DCMS about page #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content request: DCMS [1] has now been closed and we can remove the org is changing banner. department-for-business-energy-and-industrial-strategy and department-for-international-trade will be closing soon, at which point we can remove this bespoke banner code entirely. We also need to remove the banner code for the actual org page which lives in collections. Once an org is closed in Whitehall the bespoke banner gets replaced automatically as a different view is rendered [2] vs [3]. This means we don't have to remove each orgs custom banner as it gets replaced anyway. We will still need to remove the banner code in Collections when all three orgs are closed. [1]: https://www.gov.uk/government/organisations/department-for-digital-culture-media-sport/ [2]: https://github.com/alphagov/collections/blob/6ded61a31a81b7c053151bf74c80c2cd84d001e8/app/views/organisations/separate_website.html.erb#L11-L13 [3]: https://github.com/alphagov/collections/blob/6ded61a31a81b7c053151bf74c80c2cd84d001e8/app/views/organisations/show.html.erb#L7-L13
1pretz1
added a commit
that referenced
this pull request
May 12, 2023
This was asked by content. DIT and BEIS have now closed which means we can remove the transitory banners on the org about pages and the accompanying code. We've already removed DCMS's banner prior to this [1]. Trello: https://trello.com/c/ZATeFciM/5-remove-temporary-banner-for-certain-org-about-pages [1]: #2726
1pretz1
added a commit
that referenced
this pull request
May 12, 2023
This was asked by content. DIT and BEIS have now closed which means we can remove the transitory banners on the org about pages and the accompanying code. We've already removed DCMS's banner prior to this [1]. Trello: https://trello.com/c/ZATeFciM/5-remove-temporary-banner-for-certain-org-about-pages [1]: #2726
1pretz1
added a commit
that referenced
this pull request
May 12, 2023
This was asked by content DIT and BEIS have now closed which means we can remove the transitory banners on the org about pages and the accompanying code. We've already removed DCMS's banner prior to this [1]. Trello: https://trello.com/c/ZATeFciM/5-remove-temporary-banner-for-certain-org-about-pages [1]: #2726
1pretz1
added a commit
that referenced
this pull request
May 12, 2023
This was asked by content. DIT and BEIS have now closed which means we can remove the transitory banners on the org about pages and the accompanying code. We've already removed DCMS's banner prior to this [1]. Trello: https://trello.com/c/ZATeFciM/5-remove-temporary-banner-for-certain-org-about-pages [1]: #2726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content request: DCMS 1 has now been closed and we can remove the org is changing banner. department-for-business-energy-and-industrial-strategy and department-for-international-trade will be closing soon, at which point we can remove this bespoke banner code entirely.
We also need to remove the banner code for the actual org page which lives in collections. Once an org is closed in Whitehall the bespoke banner gets replaced automatically as a different view is rendered 2 vs 3. This means we don't have to remove each orgs custom banner as it gets replaced anyway. We will still need to remove the banner code in Collections when all three orgs are closed.
Trello:
https://trello.com/c/ZATeFciM/244-remove-temporary-banner-for-certain-org-about-pages
Before
After
Follow these steps if you are doing a Rails upgrade.