Replace subscription email link with component #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On service manual pages, replace the subscription email link with a subscription_links component.
patrickpatrickpatrick
force-pushed
the
replace-email-sign-up-link-on-service-manual-pages
branch
from
d732021 to
28c12f1
Compare
matthillco
approved these changes
Mar 28, 2023
patrickpatrickpatrick
deleted the
replace-email-sign-up-link-on-service-manual-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace email subscription link on service manual pages with subscription link component.
Why
Adjustment to the design of the email subscription link on service manual pages.
Visual Changes
Before
After
Follow these steps if you are doing a Rails upgrade.