Add rendering for fields of operation #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeckaL
force-pushed
the
fields-of-operation
branch
from
de192b0 to
9f617cf
Compare
The rendering for this is moving out of whitehall
BeckaL
force-pushed
the
fields-of-operation
branch
from
9f617cf to
2a1f861
Compare
This moves some hard-coded text out of the presenter
BeckaL
force-pushed
the
fields-of-operation
branch
from
2a1f861 to
efe5cab
Compare
|
Thanks @AgaDufrat for the review!
Done, thanks for the reminder! I've put the status as 'migrated' which isn't immediately strictly true right now but we'll do the work to switch over rendering app immediately after this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving the rendering for this page (/government/fields-of-operation) out of whitehall.
Screenshots:
Trello
Follow these steps if you are doing a Rails upgrade.