Add 'How Government Works' page #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
add-how-gov-works
branch
from
59b993b to
84cded9
Compare
brucebolt
force-pushed
the
add-how-gov-works
branch
from
84cded9 to
e2c27fa
Compare
brucebolt
force-pushed
the
add-how-gov-works
branch
from
e2c27fa to
80cefb5
Compare
brucebolt
force-pushed
the
add-how-gov-works
branch
from
80cefb5 to
4524b72
Compare
brucebolt
force-pushed
the
add-how-gov-works
branch
from
04699cc to
4524b72
Compare
brucebolt
force-pushed
the
add-how-gov-works
branch
from
4524b72 to
d09487c
Compare
|
Can't leave a comment in the right place! The images could be moved into the "buildings" folder, would mean we could rename the |
JonathanHallam
approved these changes
Mar 13, 2023
Yeah, I think the whole images directory needs reviewing. I didn't want to put these into
Done |
hannako
approved these changes
Mar 14, 2023
We use the `classify` method to work out the presenter name from the schema name [1]. By default, Rails singularizes names when turning them into a class. This led to us incorrectly looking for the `HowGovernmentWorkPresenter`. Adding an inflection to tell Rails that this string is the same where singlular or plural, therefore leading to the correct presenter name being used. 1: https://github.com/alphagov/government-frontend/blob/e0c26e4d7685994e1def3a19751acc7e49c97ab5/app/services/presenter_builder.rb#L41
brucebolt
force-pushed
the
add-how-gov-works
branch
from
d09487c to
60537b1
Compare
This will be used to get the relevant pieces of information from the content item for this page.
These images are included in the page, so need to be added here. The photograph of Churchill was already present in this repo as it is already included in another page.
This code has been lifted and shifted almost verbatim from Whitehall
[1].
The only changes that have been made are:
- replacing the Whitehall variable names with those used by Government
Frontend
- add links where we don't have the helper method available that are
present in Whitehall
- add missing alt text to images
- replacing a hardcoded '300+' for agencies and other public bodies with
a dynamic number that rounds down to the hundred (e.g. 480 would be
400+)
- fixed a typo ("Agencies other public bodies" to "Agencies and other
public bodies")
Text has not been added to the locale files, since this page is mostly
hardcoded content that is unlikely to be translated.
1: https://github.com/alphagov/whitehall/blob/1838b2e1aaf081165e8664cb9ee31941ac0acb3a/app/views/home/how_government_works.html.erb
The code ported from Whitehall was implementing it's own version of the big number component, so replacing to use the component instead.
brucebolt
force-pushed
the
add-how-gov-works
branch
from
60537b1 to
7880993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the How Government Works page, which is currently rendered by Whitehall.
Trello card
Follow these steps if you are doing a Rails upgrade.