Update how contents list is called #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changes in the gem mean that the `aria_label` option for the contents list component has been replaced with the `aria` option (passing a hash of aria options)
AshGDS
approved these changes
Mar 14, 2023
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates how the contents list component is called. Specifically the
aria_labeloption for the contents list component has been replaced with theariaoption (passing a hash of aria options).Why
Updates to the component in the gem mean that this option would no longer work, needed updating. Note that this PR should not be merged until the change below is merged into a new version of the gem and updated in this application as part of this PR.
Related PR: alphagov/govuk_publishing_components#3254
Visual changes
None.