Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds top margin to title component inside inverse-header #2705

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

davidtrussler
Copy link
Contributor

Github issue

This PR addresses a problem where the inverse header displays with uneven vertical spacing. This is caused by the way the component is rendered on the page rather than the component itself and requires that some extra padding is added to the top of the component so that it displays in a satisfactorily balanced way.

Current Updated
heading_before heading_after

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2705 March 1, 2023 16:56 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. The margin_top option doesn't appear to be documented in the title component, as a related piece of work, would you be able to add that?

@davidtrussler
Copy link
Contributor Author

Good fix. The margin_top option doesn't appear to be documented in the title component, as a related piece of work, would you be able to add that?

Oh yes, that's true. Yes, I'll do that as well. 👍

@davidtrussler davidtrussler merged commit 6c0ec4f into main Aug 23, 2023
@davidtrussler davidtrussler deleted the 3085_Inverse-head_Uneven-top-bottom-padding branch August 23, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants