Fix content schema tests #2666
Merged
Fix content schema tests #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo in the support file, such that GovukSchemas::Example.find_all(supported_schemas) was returning [] because the `find_all` method expects a single string param. https://github.com/alphagov/govuk_schemas/blob/4fef0aa95be24c3534a00b622a59ea7f1e8175fa/lib/govuk_schemas/example.rb#L5 Also removes redirect, as there is no frontend rendering. https://github.com/alphagov/publishing-api/tree/main/content_schemas/examples/redirect Minitest won't not run tests of the same name, and multiple schema examples have the same basepath. Hence adding in the index to the iterator.
chao-xian
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test file test/contracts/govuk_content_schemas_test.rb was not actually testing anything because there was a typo in the support file, such that GovukSchemas::Example.find_all(supported_schemas) was returning []
This is because the
find_allmethod expects a single string param. See hereAlso removes redirect, as there is no frontend rendering. https://github.com/alphagov/publishing-api/tree/main/content_schemas/examples/redirect
Minitest won't run tests of the same name, and multiple schema examples have the same basepath. Hence adding in the index to the iterator.
Follow these steps if you are doing a Rails upgrade.
https://trello.com/c/1gPCngv0/1136-migrate-service-manual-frontend-templates-into-government-frontend-m