Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe and Print Buttons on Same Row #2664

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

patrickpatrickpatrick
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick commented Jan 16, 2023

What

At the bottom of content item pages, the email subscription button and print button have been moved to be on the same row.

Why

This was a request from the designers of the Navigation and Presentation team.

Relevant Trello Card

Visual Differences

Before

Desktop

Screenshot 2023-01-16 at 15 08 26

Mobile

Screenshot 2023-01-16 at 15 08 33

After

Desktop

Screenshot 2023-01-16 at 15 09 06

Mobile

Screenshot 2023-01-16 at 15 09 11

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

At the bottom of content item pages, the email subscription button and
print button have been moved to be on the same row. This was a request
from the designers of the Navigation and Presentation team.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2664 January 16, 2023 15:08 Inactive
Copy link
Contributor

@chao-xian chao-xian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickpatrickpatrick patrickpatrickpatrick merged commit 8a69e71 into main Jan 16, 2023
@patrickpatrickpatrick patrickpatrickpatrick deleted the print-and-subscribe-same-row branch January 16, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants