Fix layout of /government/history and remove use of inline styles #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These class names don't have any effect (they are not associated with styles or scripts). I assume these are artefacts from the Whitehall -> Government Frontend migration.
This layout was broken because the figure element margins led to it exceeding it's allocated width. I opted to use a design system override class to resolve this as they seemed to be the precedent for managing the styles on this page.
The usage of inline styles is going to be disallowed at the CSP level to reduce the damage HTML injection can do [1]. This replaces the usages of these inline styles with Design System override classes. I went for these rather than creating a new class as there didn't seem to be any precedent for specific classes for this part of the site, yet a variety of precedence in using override classes. [1]: alphagov/govuk_app_config#279
patrickpatrickpatrick
approved these changes
Jan 16, 2023
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/lxxx5XLZ/178-govuk-has-a-half-implemented-content-security-policy-csp
The changes here have been made in order for this application to be compatible with the changes coming in alphagov/govuk_app_config#279, where inline styles will no longer be permitted. The scope grew a little to do a bit of a clean-up in the history pages where inline styles were present.
This change:
The layout bug is demonstrated below
Before:
After:
Follow these steps if you are doing a Rails upgrade.