Use bootsnap to improve startup time. #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
force-pushed
the
sengi/dockerfile-cleanup
branch
from
b072719 to
071ec26
Compare
nsabri1
reviewed
Dec 9, 2022
theseanything
approved these changes
Dec 9, 2022
|
Thanks! Since it's Friday afternoon and this thing's push-on-green I'll wait until Monday before merging :D |
- Add .dockerignore. docker build no longer fails when there are build artefacts in the source directory. - Use `$APP_HOME` from the base image instead of hardcoding `/app` throughout. - Remove unnecessary and misleading definition of `PORT` env var. - Re-enable bootsnap. - Simplify the command, now that we no longer need to run `bundle exec` explicitly.
sengi
force-pushed
the
sengi/dockerfile-cleanup
branch
from
071ec26 to
c5d5971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to be using bootsnap on most of the publisher apps but not on the frontends.
We don't care much about startup time per se, but reducing the CPU spike on pod startup is helpful for capacity planning and helps to keep the overall performance of the cluster more predictable.
Tested: works on the integration k8s cluster. Benchmarking locally with
docker runshowed >40% improvement in startup time and savings of roughly 2 core-seconds per pod startup. Regression tested on EC2 by deploying to the integration environment, checking that smoke tests still pass there and checking there were no errors/warnings in app logs.