Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for event tracker changes #2613

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Update for event tracker changes #2613

merged 2 commits into from
Nov 29, 2022

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Nov 28, 2022

NOT TO BE MERGED unless also including the new version of the components gem that includes the changes detailed below

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / why

Update references to GA4 event tracker to cope with breaking changes introduced in alphagov/govuk_publishing_components#3057

  • GA4 event tracker has been rewritten to use a data-ga-event attribute in place of data-ga4
  • updating for tracking on various pages for print link

Pages affected:

Also updates print link tracking for GA4 - minor change in the values passed.

Visual changes

None.

Trello cards:

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2613 November 28, 2022 14:41 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2613 November 29, 2022 09:25 Inactive
@andysellick andysellick marked this pull request as ready for review November 29, 2022 13:29
@andysellick andysellick changed the title [DO NOT MERGE] Update for event tracker changes Update for event tracker changes Nov 29, 2022
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2613 November 29, 2022 15:30 Inactive
- GA4 event tracker has been rewritten to use a `data-ga-event` attribute in place of `data-ga4`
- updating for tracking on various pages for print link
- changes some values for print link tracking in GA4
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2613 November 29, 2022 15:33 Inactive
@andysellick andysellick merged commit 35f1dc0 into main Nov 29, 2022
@andysellick andysellick deleted the update-ga4-data branch November 29, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants