Refactor single page notification button logic prior to adding new functionality #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rather than set an environment variable in the controller which is available to all the views, we should control whether or not we show the button template in the presenter. - I've removed the ALLOWED_DOCUMENT_TYPES because if we only include the ContentItem::SinglePageNotificationButton module in the presenter classes of content types which we want to show the button, the effect is the same. It's also a bit misleading having an allow list because it infers there's a reason some types can't support email subscriptions. This is not the case - email alert API doesn't care. - This pattern of including a module into the document type specific presenter is more consistent with this repo, and other frontend repos.
Currently we are requiring the single page notification button module in all the subclasses inheriting from ContentItemPresenter. We will be adding more into this module in coming work, so it's a good idea to remove unecessary coupling now.
hannako
changed the title
chao-xian
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no user facing changes here, it's just a reorganisation of the existing code.
We will soon be wanting to add the button to a new document type (document collections) with custom button text, so doing a bit of a tidy up first to make the code easier to extend.
See commit messages for more detail.
https://trello.com/c/gpch42Uc/1456-enable-custom-text-for-the-single-page-notification-button-component-l