Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run-name for deploy workflow #2589

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

theseanything
Copy link
Contributor

This updates the variable references to account for when the workflow is triggered by a CI workflow run. In that scenario the "inputs" context is blank and leads to empty strings.

This also switches other input references to use the inputs instead of github.event.inputs context. This is a more concise way to access input variables. The inputs and github.event.inputs context are exactly the same, except booleans are preserved in the inputs context.

This updates the variable references to account for when the workflow is
triggered by a CI workflow run. In that scenario the "inputs" context is
blank and leads to empty strings.
This switches the workflow to use the more concise way to access input
variables. The inputs and github.event.inputs context are exactly the
same, except booleans are preserved in the inputs context.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2589 November 1, 2022 16:18 Inactive
@theseanything theseanything merged commit 7fdb746 into main Nov 1, 2022
@theseanything theseanything deleted the bulk/fix-run-name-in-deploy-workflow branch November 1, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants