Update links in Webchat README #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After talking to HMPO and their new service provider, it became clear that they were looking at an old version of the code for the Webchat implementation and quoting incorrect polling times etc. Removing the link to a specific commit means that we are always linking to the current version of the code. There is a risk that the file could move and the link could break, but if that seems a more acceptable than having to also update these docs if any of the hardcoded values change. Also removes the jQuery example code and replaces it with vanilla Javascript as jQuery has been removed from all of the frontend GOV.UK applications and we don't want to encourage its return.
sihugh
approved these changes
Sep 26, 2022
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to HMPO and their new service provider, it became clear that they were looking at an old version of the code for the Webchat implementation and quoting incorrect polling times etc.
Removing the link to a specific commit means that we are always linking to the current version of the code.
There is a risk that the file could move and the link could break, but if that seems a more acceptable risk than having to also update these docs if any of the hardcoded values change.
Also removes the jQuery example code and replaces it with vanilla Javascript as jQuery has been removed from all of the frontend GOV.UK applications and we don't want to encourage its return.