Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object Object] 'text' values for accordions on manual_section pages #2542

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

gclssvglx
Copy link
Contributor

@gclssvglx gclssvglx commented Sep 7, 2022

What

Use only the text attribute of the object that is used to render the accordion headings on manual sections.

Why

Currently, when the value arrives in Google Analytics (GA) the ga4['text'] value is showing as [object Object] and not a simple string. Looking at the values within the HTML for the accordion, a sub-object is clearly visible (see before screenshot).

Screenshot

Before After
Screenshot 2022-09-07 at 10 07 07 Screenshot 2022-09-07 at 10 07 35

Trello

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Use only the 'text' attribute of the object used to render the heading of accordions on
manual sections.

Why

Currently, when the value arrives in Google Analytics (GA) the ga4['text'] value is
showing as '[object Object]' and not a simple string.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2542 September 7, 2022 09:13 Inactive
@gclssvglx gclssvglx merged commit 5e21754 into main Sep 7, 2022
@gclssvglx gclssvglx deleted the object-not-text-on-manual-pages branch September 7, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants