Add single page notification button to document collections #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
force-pushed
the
spike_notifications
branch
from
d3d7ee3 to
81425f2
Compare
hannako
force-pushed
the
spike_notifications
branch
from
81425f2 to
445a15f
Compare
hannako
force-pushed
the
spike_notifications
branch
from
445a15f to
bcb33ca
Compare
hannako
force-pushed
the
spike_notifications
branch
from
a40e6a9 to
5373df5
Compare
hannako
force-pushed
the
spike_notifications
branch
from
e0f8fa1 to
2388ed7
Compare
hannako
force-pushed
the
spike_notifications
branch
from
2388ed7 to
6db7a0a
Compare
hannako
force-pushed
the
spike_notifications
branch
from
6db7a0a to
d5b6934
Compare
hannako
force-pushed
the
spike_notifications
branch
2 times, most recently
from
e216f90 to
9e3a2f1
Compare
Tetrino
approved these changes
Feb 6, 2023
hannako
force-pushed
the
spike_notifications
branch
from
9e3a2f1 to
6ae6fe8
Compare
hannako
force-pushed
the
spike_notifications
branch
from
6ae6fe8 to
d6dd9cb
Compare
BeckaL
reviewed
Jun 30, 2023
hannako
force-pushed
the
spike_notifications
branch
from
d6dd9cb to
ecea8c8
Compare
hannako
force-pushed
the
spike_notifications
branch
from
ecea8c8 to
991b3a9
Compare
The single page notification button component, by default, enforces creating/signing in to a gov.uk account. It has a default form action of "/email/subscriptions/single-page/new". Passing in the optional paramater `skip_account` sets a form action of "/email-signup" which does not enforce the gov.uk account See govuk_publishing_components/presenters/single_page_notification_button_helper.rb#L63-L69
hannako
force-pushed
the
spike_notifications
branch
from
991b3a9 to
f766dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the single page notification button to document collections. Pass in the
skip_accountflag to the component so that users sign up via the non GOV.UK account route.Review app: https://government-frontend-pr-2535.herokuapp.com/government/collections/technology-case-studies
Related work:
Trello: https://trello.com/c/fXCk2Vck/1614-turn-on-email-notifications-for-document-collections-m