Add GA4 accordion tracking to manuals #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
d934314 to
bf12e73
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
bf12e73 to
8314af9
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
8314af9 to
6c77bdd
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
6c77bdd to
824f08d
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
824f08d to
b1db951
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
b018d87 to
cd1d2c9
Compare
gclssvglx
changed the title
gclssvglx
changed the title
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
ee224ed to
4b4499e
Compare
gclssvglx
changed the title
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
4b4499e to
331ac86
Compare
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
331ac86 to
2ef39d6
Compare
andysellick
reviewed
Aug 15, 2022
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
2ef39d6 to
e4201c3
Compare
andysellick
reviewed
Aug 15, 2022
Currently, the title string that is added to the data-ga4 title tag contains the manuals.updates_amendments I18N string, this is not stripped and is unwanted. This change adds a helper for sanitising the title string before being added to data-ga4. Tests are also added.
Currently, the I18N manuals.updates_amendments string is visible on the rendered page. This is because the GOV.UK visuallyhidden class has been replaced by the govuk-visually-hidden class. We need to replace the visuallyhidden class and update the appropriate tests.
gclssvglx
force-pushed
the
ga4-tracking-accordions
branch
from
e4201c3 to
3f631ae
Compare
andysellick
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently working to complete the implementation of GA4 tracking on all accordions, across all frontend apps.
This PR adds tracking to the accordions on the following pages:
Example URL(s):
There are more example pages listed in the manuals publisher docs.
Also, in this PR is a bug fix. Currently, the I18N
manuals.updates_amendmentsstring is visible on the rendered page. This is because thevisuallyhiddenclass has been replaced by thegovuk-visually-hiddenclass. Thevisuallyhiddenclass has been replaced and appropriate tests added.Co-authored-by: Graham Lewis <@gclssvglx>
Trello