Visa service recruitment banner #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding a new recruitment banner to visa pages, so we need to be rename things a bit first.
hannako
force-pushed
the
visa_recruitment_banner
branch
from
e0a4fdb to
d6afe1d
Compare
AgaDufrat
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
LGTM. Testing all pages would warn us if we are trying to recruit users for more than one test on the same page.
If it happens that one of the Visa tests pages is tagged to "Working..." browse, the test URL would be for the Tree test. We should probably mention this the UR. If that would be an issue we should probably ask which test should take priority.
|
@AgaDufrat Yes that's correct - I've set it so tree test trumps visa test. I didn't check every content item, but I checked the first 5 or so and none of those were tagged to our browse category of interest so I don't THINK it will be an issue. But I'll make a note on the trello card for Lorna 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recruitment banner to pages related to the UK visa service.
See trello card for list of pages.