Rails 7 upgrade #2490
Merged
Rails 7 upgrade #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validate_locales test failed with
Expected: [:few, :one, :other], actual: [:few, :many, :one, :other]
Autoloading during initialization will error in Rails 7. Applications that autoloaded reloadable constants during initialization outside of to_prepare blocks got those constants unloaded. https://guides.rubyonrails.org/v7.0/upgrading_ruby_on_rails.html#autoloading-during-initialization
Sprockets is now an optional dependency https://guides.rubyonrails.org/v7.0/upgrading_ruby_on_rails.html#sprockets-is-now-an-optional-dependency
In rails 7 redirects to other hosts are no longer permitted by default and ActionController::Redirecting::UnsafeRedirectError was raised. However in all those cases we are redirect to other GOV.UK domains such as assets.gov.uk or service.gov.uk.
chao-xian
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/8ke6EUY0/1093-rails-7-update-government-frontend