Migrate to jasmine browser #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `yarn add -D jasmine-browser-runner jasmine-core`
chao-xian
force-pushed
the
migrate-to-jasmine-browser
branch
2 times, most recently
from
ceb58f4 to
4548291
Compare
chao-xian
commented
Jul 18, 2022
Adds vendor helper files for the JS tests. Need to be loaded in order. See https://jasmine.github.io/setup/browser.html
This app also has some webchat JS and vendor helpers for it that need to be included.
These are deprecated and we should now be able to just use jasmine-browser-runner and unblock Rails 7 upgrades. See https://github.com/jasmine/jasmine-gem#discontinued
chao-xian
force-pushed
the
migrate-to-jasmine-browser
branch
from
a35f939 to
8979aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jasmine-railsis now deprecated and we should switch to use jasmine-browser-runner and unblock Rails 7 upgrades.