Tidy up stylesheets and JavaScript #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
approved these changes
Jul 7, 2022
Both the accordion and organisation logo components have print stylesheets, which weren't being included in this app's print stylesheet.
injms
force-pushed
the
tidy-up-stylesheets-and-javascript
branch
from
54ce303 to
9933e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
component_supportReduces
applications.cssfrom 287.91 kB to 218.13 kB uncompressed.Reduces
application.jsfrom 116.95 kB to 109.60 kB uncompressed.Why
Component support includes a set of base styles needed by the components; and component styles used by multiple rendering applications are also included in
static's stylesheet. Because both of this they don't need to be duplicated ingovernment-frontend.The missing print stylesheets needed to be included to ensure a consistent print experience across GOV.UK - missing them out of one application would mean that these components would print differently depending on which page was being printed.
Visual changes
None.