Enable CI in GitHub Actions #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
force-pushed
the
deploy-commit-gha
branch
from
6b35357 to
09a4e77
Compare
theseanything
force-pushed
the
deploy-commit-gha
branch
2 times, most recently
from
ad953d3 to
417cf54
Compare
This prevents the deploy workflow from being run before the application tests have been completed. This is to ensure that the commit passes application tests before being deployed. The 'workflow_run' trigger is being used as these events cannot be triggered directly by users. This is to prevent non-production team members from deploying. The 'repository_dispatch' and 'deployment' trigger were also considered, however those events can be directly created via API calls hence would give deploy access to non-production users (as we assign them "write" roles to repos and GitHub currently doesn't provide more fine grained access controls).
theseanything
force-pushed
the
deploy-commit-gha
branch
from
417cf54 to
5ea947f
Compare
theseanything
changed the title
marcpomfret
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a GitHub Action workflow to run CI using a re-usable workflow template in govuk-infrastructure repo. This is part of the re-platforming work as we migrate away from Jenkins.