Use govuk design system information banner for historical editions and html attachments #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgisbey
force-pushed
the
use-govuk-design-system-information-banner-for-historical-editions
branch
2 times, most recently
from
f5dcf61 to
a55033b
Compare
beccapearce
approved these changes
May 31, 2022
This now uses the publishing component notice component.
This does the work to ensure that if a html attachment is historically political then the history notice banner is rendered like it is for various other document types such as News Articles.
davidgisbey
force-pushed
the
use-govuk-design-system-information-banner-for-historical-editions
branch
from
a55033b to
9c9e46a
Compare
davidgisbey
deleted the
use-govuk-design-system-information-banner-for-historical-editions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're doing some work to expose a history banner on html attachments to let the user know that a publication was published under a previous government. This means that we need to expose whether a html publication is political and which government it was published under on the object passed to the frontend.
This PR exposes the history banner on the Frontend when a html publication is historically political
Whitehall PR
alphagov/whitehall#6585
GOVUK Content Schema PR
alphagov/govuk-content-schemas#1096
Trello card
https://trello.com/c/xWMcmTqb/409-implement-history-mode-banner-on-html-attachments