Use manual timestamps for manual section header #2441
Merged
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1pretz1
force-pushed
the
update-timestamps-for-sections
branch
2 times, most recently
from
3e77158 to
4eb33f4
Compare
Currently (in Government Frontend) , a manual section's timestamps for published at and last updated at originate from the manual section. However, the live version (Manuals Frontend) uses the parents manual timestamps. This commit applies parent manuals timestamps as we should keep the behaviour the same. Also adds missing tests for a normal manual section.
1pretz1
force-pushed
the
update-timestamps-for-sections
branch
from
4eb33f4 to
f7f1ea0
Compare
edwardkerry
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (in Government Frontend) , a manual section's timestamps for
published at and last updated at originate from the manual section.
However, the live version (Manuals Frontend) uses the parents manual
timestamps. This commit applies parent manuals timestamps
as we should keep the behaviour the same.
Tests dependant on:
Parent manual's header
Manual section (before)
Manual section (after)
Trello:
https://trello.com/c/qCSHqqN7/1287-use-parent-manual-timestamps-for-manual-sections