Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Prometheus Exporter for EKS only #2440

Merged
merged 2 commits into from
May 17, 2022
Merged

Enable Prometheus Exporter for EKS only #2440

merged 2 commits into from
May 17, 2022

Conversation

fredericfran-gds
Copy link
Contributor

@fredericfran-gds fredericfran-gds commented May 16, 2022 •
edited
Loading

  • Updated govuk_app_config to 4.5 to enable prometheus exporter to
    be set in specific environment by setting the environment variable
    GOVUK_PROMETHEUS_EXPORTER to true

  • Update Dockerfile for image to have env GOVUK_PROMETHEUS_EXPORTER set to true

  • add prometheus initializer code

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@fredericfran-gds
Update govuk_app_config for prometheus_exporter functionality
38f666d 
Updated govuk_app_config to 4.5 to enable prometheus exporter to
be set in specific environment by setting the environment variable
`GOVUK_PROMETHEUS_EXPORTER` to `true`
@fredericfran-gds
add prometheus initializer
eed835a
@fredericfran-gds fredericfran-gds marked this pull request as ready for review May 16, 2022 15:34
smford
smford approved these changes May 17, 2022
View reviewed changes
Copy link

@smford smford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fredericfran-gds fredericfran-gds changed the title Monitoring test Enable Prometheus Exporter for EKS only May 17, 2022
@fredericfran-gds fredericfran-gds merged commit 3e952b5 into main May 17, 2022
@fredericfran-gds fredericfran-gds deleted the monitoring_test branch May 17, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smford smford smford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericfran-gds @smford