Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_publishing_components from 28.9.2 to 29.0.0 #2403

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 25, 2022

Bumps govuk_publishing_components from 28.9.2 to 29.0.0.

Changelog

Sourced from govuk_publishing_components's changelog.

29.0.0

Commits
  • 8eeaa2c Merge pull request #2696 from alphagov/version-29.0.0
  • fb26fdc Version 29.0.0
  • ad6a892 Merge pull request #2613 from alphagov/remove-jq-from-modules-js
  • 691eed5 Update changelog
  • dbcbb36 Remove references to jQuery dependency
  • 319a4cb Update documentation for jQuery removal
  • 613cfcc Remove jQuery from the components gem
  • 35ec75f Merge pull request #2686 from alphagov/add-border
  • 07739dc Merge pull request #2692 from alphagov/kevindew-patch-1
  • 4f441c7 Add border to search icon - JS disabled
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 28.9.2 to 29.0.0.
- [Release notes](https://github.com/alphagov/govuk_publishing_components/releases)
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v28.9.2...v29.0.0)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Mar 25, 2022
@govuk-ci govuk-ci had a problem deploying to government-f-dependabot-auhlhu March 25, 2022 11:02 Failure
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 11:51 Inactive
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-29.0.0 branch from 851d669 to 96a9e98 Compare March 25, 2022 12:39
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 12:39 Inactive
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-29.0.0 branch from 96a9e98 to 2cbe9e7 Compare March 25, 2022 12:42
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 12:42 Inactive
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-29.0.0 branch from 2cbe9e7 to d5abb12 Compare March 25, 2022 12:43
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 12:43 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff looks almost there

test/test_helper.rb Outdated Show resolved Hide resolved
app/assets/config/manifest.js Show resolved Hide resolved
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-29.0.0 branch from d5abb12 to b82889b Compare March 25, 2022 14:47
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 14:47 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super, just one line extra was removed than needed.

test/test_helper.rb Outdated Show resolved Hide resolved
- add manifest.js, this is now needed as part of the upgrade to sprockets, see https://github.com/rails/sprockets/blob/master/UPGRADING.md
- remove webdrivers, as now using chromedriver
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-29.0.0 branch from b82889b to fedc39e Compare March 25, 2022 14:58
@govuk-ci govuk-ci temporarily deployed to government-f-dependabot-iaysk9 March 25, 2022 14:58 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks

@andysellick andysellick merged commit eca0d46 into main Mar 25, 2022
@andysellick andysellick deleted the dependabot/bundler/govuk_publishing_components-29.0.0 branch March 25, 2022 15:26
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 25, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants