Update email subscription banner content #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the single page notification success banner content based on input from our designers and reduce some repetition in the email_subscribe_unsubscribe_flash partial
alex9smith
reviewed
Mar 9, 2022
| @@ -46,6 +48,10 @@ def service_sign_in_options | |||
| end | |||
| end | |||
|
|
|||
| def show_email_subscription_success_banner? | |||
There was a problem hiding this comment.
When we have a helper method that's needed in the view but not the controller, we usually put it in its own helper file - see this comment from Huw explaining it on one of my PRs.
So in this case we'd have a app/helpers/content_items_helper.rb file with a ContentItemsHelper class and this method.
What do you think?
There was a problem hiding this comment.
Thank you @alex9smith, that makes sense, I get fuzzy on what is best practice sometimes, it's good to be reminded!
I've made the changes as suggested, let me know if that's okay.
alex9smith
reviewed
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the single page notification success banner content based on
input from our designers and reduce some repetition in the
email_subscribe_unsubscribe_flashpartialhttps://trello.com/c/bPoMTXr0