Display intervention banner on specific pages for User Research #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for testing against specific pages when we needed.
chao-xian
changed the title
chao-xian
force-pushed
the
recruitment-banner
branch
from
eb209f7 to
7596e60
Compare
Tetrino
reviewed
Mar 7, 2022
| <% if @content_item.show_phase_banner? %> | ||
| <% if @content_item.show_study_banner? %> | ||
| <%= render "govuk_publishing_components/components/intervention", { | ||
| suggestion_text: "Help improve GOV.UK", |
There was a problem hiding this comment.
Do we have these in i18n anywhere?
Tetrino
approved these changes
Mar 7, 2022
|
@Tetrino I had that same option in Collections but the gem for GOV.UK Translations checks that you have keys in all of the lang files, and fails it as a lint error unless all the 60ish files have keys. Given that the banner is temporary and will only be in English I'm ok with it being hardcoded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Adds the intervention banner to specific pages that links to a tree test that User Research want to conduct.
Trello card
Screenshots
Before
After