Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessible form link #2372

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Add accessible form link #2372

merged 1 commit into from
Mar 10, 2022

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Feb 25, 2022

These are needed to render the new accessible form link from GOVUK
Publishing Components. This is dependant on the component being updated
first 1.

This change will apply to publications and consultations, which use the
attachments partial. Initially, the new flow of requesting accessible
formats will be a pilot and only available for documents, owned by a few
organisations. This code will not need to be changed when the change is
released to all orgs.

App tests will not pass until 1 has been merged

Running code locally against 1

Screenshot 2022-02-25 at 16 21 11

Trello: https://trello.com/c/FdQvPVhD/1094-accessible-format-request-government-frontend-add-parent-document-contentid-to-the-attachment-model

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to government-f-add-access-aylly3 February 25, 2022 13:43 Inactive
@1pretz1 1pretz1 force-pushed the add-accessible-form-link branch from f086287 to 4714653 Compare February 25, 2022 16:21
@govuk-ci govuk-ci temporarily deployed to government-f-add-access-cobwre February 25, 2022 16:22 Inactive
@1pretz1 1pretz1 marked this pull request as ready for review February 25, 2022 16:26
@1pretz1 1pretz1 force-pushed the add-accessible-form-link branch from 4714653 to c4a5509 Compare February 25, 2022 17:43
@govuk-ci govuk-ci temporarily deployed to government-f-add-access-cobwre February 25, 2022 17:43 Inactive
Copy link
Contributor

@edwardkerry edwardkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look OK to me, thanks Pete! Will wait until publishing components is finalised and tests passing before approving though just in case.

These are needed to render the new accessible form link from GOVUK
Publishing Components. This is dependant on the component being updated
first [1].

This change will apply to publications and consultations, which use the
attachments partial. Initially, the new flow of requesting accessible
formats will be a pilot and only available for documents, owned by a few
organisations. This code will not need to be changed when the change is
released to all orgs.

[1]: alphagov/govuk_publishing_components#2636
@1pretz1 1pretz1 force-pushed the add-accessible-form-link branch from c4a5509 to 711ce3c Compare March 3, 2022 12:19
@1pretz1
Copy link
Contributor Author

1pretz1 commented Mar 3, 2022

Rebased the PR which uses the latest version of GOVUK Publishing Components so probably could do with a re-review @edwardkerry if you would be so kind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants