Remove Wraith dependencies and configuration #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions before 1.15 don't work with Arm64 architecture.
This is no longer used by GitHub and this app actually has a different one in .github/pull_request_template.md
I'm intending to remove the Wraith gem from this project so a prerequisite step is to extract the shared config. This contains the exact same links as is used in the test/wraith/config.yaml file - with comments preserved.
The wraith tests for this repo are no longer a part of the review/CI process and no longer run. The Wraith gem itself has not had further development since 2019. My impetus to remove this was that one of Wraith's dependencies, chromedriver-helper, actually causes problems by installing a chromedriver binary that can conflict with system installed ones.
kevindew
force-pushed
the
remove-wraith
branch
from
633eb0f to
7dae76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wraith tests for this repo are no longer a part of the review/CI
process and no longer run. The Wraith gem itself has not had further
development since 2019.
My impetus to remove this was that one of Wraith's dependencies,
chromedriver-helper, actually causes problems by installing a
chromedriver binary that can conflict with system installed ones.