Set Urdu text direction to right-to-left #2339
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuriloDalRi
approved these changes
Jan 19, 2022
maxgds
approved these changes
Jan 19, 2022
injms
force-pushed
the
set-urdu-text-direction
branch
from
962f439 to
de780cc
Compare
|
Force pushed a no-change amend to kick the CI into running, as Jenkins wasn't doing anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sets the
i18n.directionkey in the Urdu language file to right-to-left.Why
This key used by application to determine whether the direction that text should be displayed:
ttps://github.com/alphagov/government-frontend/blob/4fab76c1cc871f3da91592a88a1b06f94922d58d/app/helpers/application_helper.rb#L3
Urdu was missing this key, so was defaulting to displaying it left-to-right.
Visual differences
Before:
After:
From https://www.gov.uk/government/news/innovative-afghan-businesses-receive-uk-aid-grants.ur