Undo temporary workaround in pull request #2330 #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2330 added an additional div around published-dates to prevent this change in govuk_publishing_components being a breaking one: alphagov/govuk_publishing_components#2558 This additional div is now safe to remove and the id of the wrapper for published-dates can be updated to the new one.
danacotoran
force-pushed
the
undo-temp-workaround-for-metadata-link
branch
from
dab9c5e to
6e46f36
Compare
maxgds
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2330 added an additional div around
published-datesto prevent thischange in
govuk_publishing_componentsbeing a breaking one:alphagov/govuk_publishing_components#2558
This additional div is now safe to remove and the id of the wrapper for
published-datescan be updated to the new one.Fixes alphagov/govuk_publishing_components#600