Turn scroll tracking on for various pages #2324
Conversation
andysellick
changed the title
There was a problem hiding this comment.
Nice one! looks a big improvement on the masses of configuration in: https://github.com/alphagov/govuk_publishing_components/pull/2548/files
I think I've caught a small issue with guides, otherwise I've done a quick skim the paths match the source PR but I've not been too thorough.
| "/taking-goods-out-uk-temporarily/get-an-ata-carnet", | ||
| ] | ||
|
|
||
| full_url = [@content_item.base_path, @content_item.part_slug].join('/') |
There was a problem hiding this comment.
I'm not sure this will operate correctly, given the paths you have listed above.
I assume we're expecting part_slug to sometimes be nil in order to have paths like "/council-housing", however if we do ["/council-housing", nil].join("/") we get /council-housing/. Perhaps you want to do [@content_item.base_path, @content_item.part_slug].compact.join('/') ?
There was a problem hiding this comment.
Great spot, thanks! Have updated.
There was a problem hiding this comment.
The trello card links to a spreadsheet of all these URLs and some more details about them, including what the original tracking was and what changes have been made. Each one falls into one of these categories:
- not needed and scroll tracking has (probably already) been removed
- was tracking headings but content has changed so no tracking was occurring, so have removed tracking
- was tracking headings or percentages so has been migrated to the new scroll tracker
andysellick
force-pushed
the
migrate-to-new-scrolltracker
branch
from
c51c656 to
e0ca197
Compare
andysellick
changed the title
What
Turn on scroll tracking for various pages.
NOTE this change depends on this change in the components gem being deployed to
staticat the same time, otherwise duplicate or no scroll tracking events may occur.Why
We're retiring the old scroll tracker and migrating all pages that use it to the new one.
Visual changes
None.
Trello card: https://trello.com/c/sdugtMbX/37-migrate-to-new-scroll-tracker