Add notification button to detailed guide template #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
approved these changes
Dec 8, 2021
danacotoran
changed the title
barrucadu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback we received following our original rollout of the single page notification button to a couple of pages, the GOVUK Accounts team are moving forward with adding the single page notification button to a few additional pages.
Some of these pages are
detailed_guidepages rather thanpublications.This adds the button to the
detailed_guidetemplate, and adds the paths of the new pages to the list incontent_items_controller.rb.https://trello.com/c/GHkbMziw/1172-enable-single-page-notifications-on-more-pages
https://trello.com/c/fGfa64jD