Import missing translations #2305
Conversation
Import translations missed out of the original import from the supplier (ASP). `bundle exec rake translation:import['dir/to/csv.csv']`
Renames the text keys and adds link.
bundle exec rake translation:normalize
| @@ -371,10 +371,10 @@ ur: | |||
| release_date: اجراء کی تاریخ | |||
There was a problem hiding this comment.
I noticed two keys whose values contain HTML, but the key names don't end in _html - were they missed?
There was a problem hiding this comment.
This confused me for a second! 😆 Those keys are actually unused and have been removed in the the following commit: 45d2065#diff-f8ecf4cd17cdd1ecc6f81401e44eba0a0e3c55ff9cd30b5acd1a3c4029fc5638L38-L39
There was a problem hiding this comment.
Great - thanks for confirming!
| @@ -631,6 +631,7 @@ ar: | |||
| engage_with_gov: | |||
| fcdo_bloggers: | |||
| follow: | |||
| follow_links: | |||
There was a problem hiding this comment.
Do you know what the next steps are in terms of getting this key translated?
There was a problem hiding this comment.
Nope, unfortunately! Currently there is no contingency plan for importing translations. The mission got cut short 😢 I'm hoping the next team that inherits this work (Find and view which I'm moving to) can prioritise it, but we'll see.
Safeguard against raw HTML being rendered in the application. See [1] for more information. [1]: https://guides.rubyonrails.org/i18n.html#using-safe-html-translations
bundle exec i18n-tasks remove-unused
bundle exec rake translation:add_missing
1pretz1
force-pushed
the
import-missing-translations
branch
from
0e12395 to
a2513fb
Compare
These languages were originally missed out from the supplier (ASP) and so this PR imports them.
Original import PR: #2285
More info in the commits ->
Trello:
https://trello.com/c/Xz78vNR4/2757-import-newly-sourced-translations-into-locale-files-5