Remove unused div from get involved inset text #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a <div>..</div> that isn't necessary in the get involved page's "next closing" inset text component.
owenatgov
approved these changes
Nov 22, 2021
brucebolt
added a commit
to alphagov/smokey
that referenced
this pull request
Nov 23, 2021
An unused div was removed from the Get Involved page in [1] in order to fix the `And it should be populated` step of this test. However this now causes the `When I click the next closing response link` step to fail, as the div is no longer present. Updating the test to match the government-frontend changes. 1: alphagov/government-frontend#2296
brucebolt
added a commit
to alphagov/smokey
that referenced
this pull request
Nov 23, 2021
An unused div was removed from the Get Involved page in [1] in order to fix the `And it should be populated` step of this test. However this now causes the `When I click the next closing response link` step to fail, as the div is no longer present. Updating the test to match the government-frontend changes. 1: alphagov/government-frontend#2296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a
<div>..</div>that isn't necessary in the get involved page's "next closing" inset text component.This was causing Smokey to fail on this following selector.