Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment #2294

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add comment #2294

merged 1 commit into from
Feb 4, 2022

Conversation

chris-gds
Copy link

@chris-gds chris-gds commented Nov 19, 2021

What

Add comment

Why

Add a contextual comment / docs - indicating to future developers that changes to this page might impact smokey tests

Indicating to future developers that change might impact smokey tests
@govuk-ci govuk-ci temporarily deployed to government-f-add-smokey-n8gilc November 19, 2021 10:35 Inactive
@chris-gds chris-gds requested a review from Tetrino November 19, 2021 15:43
Copy link
Contributor

@Tetrino Tetrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that's needed really - good thinking.

@chris-gds
Copy link
Author

chris-gds commented Nov 22, 2021

Thanks for approving, have you got auth to merge this one too? @Tetrino

@chao-xian chao-xian merged commit 5f0256b into main Feb 4, 2022
@chao-xian chao-xian deleted the add-smokey-comment branch February 4, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants