Add the single page notification button to publication template #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
add_the_button_to_template
branch
from
14b35cb to
3602f43
Compare
danacotoran
force-pushed
the
add_the_button_to_template
branch
from
3602f43 to
5e963a5
Compare
huwd
reviewed
Nov 17, 2021
| @@ -134,6 +134,10 @@ def render_template | |||
| return | |||
| end | |||
|
|
|||
| # use these and `@content_item.base_path` in the template | |||
| @notification_button_visible = in_single_page_notifications_trial? | |||
There was a problem hiding this comment.
These could work as helpers, but I think this is good for now?
danacotoran
force-pushed
the
add_the_button_to_template
branch
from
5e963a5 to
ac34b41
Compare
huwd
approved these changes
Nov 17, 2021
danacotoran
changed the title
danacotoran
force-pushed
the
add_the_button_to_template
branch
from
ac34b41 to
090a832
Compare
andysellick
reviewed
Nov 18, 2021
danacotoran
changed the title
danacotoran
force-pushed
the
add_the_button_to_template
branch
from
090a832 to
a995197
Compare
andysellick
approved these changes
Nov 18, 2021
danacotoran
changed the title
If we only want to show the button on certain pages, and only have the javascript behaviour if the user has a session cookie, then we'll need these controller changes.
This option is necessary to achieve correct spacing when the email notification button is added after the published_dates component
barrucadu
force-pushed
the
add_the_button_to_template
branch
from
a995197 to
4c883d1
Compare
barrucadu
changed the title
barrucadu
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Single page notification button to the
publicationtemplate, after the metadata blocks at the top and bottom of the page.We only want to launch with a couple of pages in the initial stages, therefore the button will initially show up only on the pages listed on
in_single_page_notifications_trial?undercontent_items_controller.rb