Fix font colour being black #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be #0b0c0c as per our designs.
owenatgov
reviewed
Nov 11, 2021
There was a problem hiding this comment.
Nice! Without checking why your tests are failing, I can see you put a double semi-colon on line 4.
Also, it's not part of the PR but I can see in this component that on lines 16 and 25 we could be using govuk-spacing instead of px values.
I'm also having a think about no-js/no-css view for this and if that js-enabled is a bad way to do this but that's a problem for another day. Once the above 2 points are sorted I'm happy to approve this.
chao-xian
force-pushed
the
fix-font-colour
branch
from
80cb396 to
e06f379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be #0b0c0c as per our designs.
Fixes #2278
Before
After