Fix get-involved styles
#2264
Merged
Fix get-involved styles
#2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-ju
commented
Nov 2, 2021
alex-ju
commented
| Before | After |
|---|---|
|
|
|
When porting this page from whitehall (which still uses leaking styles from the legacy govuk-frontend-toolkit) we missed explicitly adding the `govuk-link` in a few instances.
We have pre-defined styles for hr elements in govuk-frontend, so we drop custom styles in favour of existing ones.
A `content_tag` helper was defined on L45, closing with and `end` on L48, hence this </li> is redundant.
When defining the main page header we use the title component by convention. This renders an H1 element with the associated styles. We also remove the elements that wrap this component as none of classes used are defined anywhere in this application (`block`, `headings-block`, `inner-block` or `floated-children`) – presumably remnants from when moved from whitehall.
There are two main headings and associated sections on this page `engage-with-government` and `take-part`, both linked to from the lead paragraph. The `take-part` section was given the wrong id, presumably by copying the previous section, so we correct this. Because of the broken layout of the page (a set of floating elements) these sections need a clear property, otherwise the in-page link won't work.
Because of the broken layout of the page (a set of floating elements) the `govuk-section-break` `<hr>` elements are not showing up without clearing the floating element that precede them.
ChrisBAshton
approved these changes
Nov 2, 2021
injms
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.