Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll tracking to foreign travel advice pages #2224

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Sep 22, 2021

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Adds scroll tracking to the pages listed on https://www.gov.uk/foreign-travel-advice (but not that page itself). Should add tracking for all pages for all countries, for example on:

(etc.)

Uses the new AutoScrollTracker module, initialised as a meta tag, configured to track headings. This is included in the latest version of the gem, which has already been added to government-frontend (this PR rebased to match).

Why

We want to understand user behaviour on these pages in order to improve them.

Visual changes

None.

Trello card: https://trello.com/c/JREgQ2iv/579-spike-into-tracking-enhancements

@govuk-ci govuk-ci temporarily deployed to government-f-add-scroll-ad4hf5 September 22, 2021 13:13 Inactive
- uses the new AutoScrollTracker module, initialised as a meta tag, configured to track headings
@andysellick andysellick force-pushed the add-scroll-tracking-travel-advice branch from 47e9dc2 to d308178 Compare September 23, 2021 14:30
@andysellick andysellick changed the title [DO NOT MERGE] Add scroll tracking to foreign travel advice pages Add scroll tracking to foreign travel advice pages Sep 23, 2021
@govuk-ci govuk-ci temporarily deployed to government-f-add-scroll-ad4hf5 September 23, 2021 14:31 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

I had some trouble testing this out because Static on production doesn't yet contain this file (so ./startup --live didn't work). Thought I'd mention so you don't merge this and find it doesn't work in prod because Static is behind.

@andysellick
Copy link
Contributor Author

I had some trouble testing this out because Static on production doesn't yet contain this file (so ./startup --live didn't work). Thought I'd mention so you don't merge this and find it doesn't work in prod because Static is behind.

Oh of course 🤦 . I'll make sure static has the new version so you can check it before I merge.

@kevindew
Copy link
Member

I had some trouble testing this out because Static on production doesn't yet contain this file (so ./startup --live didn't work). Thought I'd mention so you don't merge this and find it doesn't work in prod because Static is behind.

Oh of course 🤦 . I'll make sure static has the new version so you can check it before I merge.

Thanks, don't worry about me needing to check it though. I used integration yesterday to try it out.

@andysellick andysellick merged commit de4d5eb into main Sep 24, 2021
@andysellick andysellick deleted the add-scroll-tracking-travel-advice branch September 24, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants