Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax on context param #2210

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fix syntax on context param #2210

merged 1 commit into from
Aug 24, 2021

Conversation

maxgds
Copy link
Contributor

@maxgds maxgds commented Aug 24, 2021

This is a bug fix for the exposed context hash on some history pages. We removed the ability to link context text in the gem and I removed the href from the context hash, but mistakenly left the hash in situ leading to the following visual bug:

Screenshot 2021-08-24 at 16 35 09

Sample broken page: https://www.gov.uk/government/history/lancaster-house

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@bevanloon bevanloon temporarily deployed to government-f-fix-contex-sgbyd3 August 24, 2021 15:36 Inactive
@maxgds maxgds merged commit 2ffc7ec into main Aug 24, 2021
@maxgds maxgds deleted the fix-context branch August 24, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants