Remove @import of empty print stylesheets #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
changed the title
There was some refactoring to remove display: none rules from component stylesheets in favour of using the govuk-!-display-none-print class instead. alphagov/govuk_publishing_components#1561 As a consequence of this, some of the component print stylesheets which previously used to contain CSS are now empty files. This removes references to these files from the application print stylesheet.
danacotoran
force-pushed
the
remove-empty-stylesheet-import
branch
from
4d6f4d0 to
1b746e9
Compare
andysellick
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some refactoring to remove
display: nonerules from component stylesheets in favour of using thegovuk-!-display-none-printclass instead: alphagov/govuk_publishing_components#1561As a consequence of this, some of the component print stylesheets which previously used to contain CSS are now empty files. This removes references to these files from the application print stylesheet.
Relevant issue: alphagov/govuk_publishing_components#2065