Do not check if a page is saved if a user has no session header #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spotted that the account-api was getting a *lot* of saved-page queries in staging, which I tracked down to this: we're checking if the page is saved even if the user has no session (which will always fail). We can skip the API call in that case. We had a similar issue once in the Transition Checker, where we were trying to fetch saved results regardless of whether the user had a session or not. Since this has come up twice now we should think about how this problem can be solved generically. Maybe we could put more logic in gds-api-adapters, for example?
danacotoran
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted that the account-api was getting a lot of saved-page
queries in staging, which I tracked down to this: we're checking if
the page is saved even if the user has no session (which will always
fail). We can skip the API call in that case.
We had a similar issue once in the Transition Checker, where we were
trying to fetch saved results regardless of whether the user had a
session or not. Since this has come up twice now we should think
about how this problem can be solved generically. Maybe we could put
more logic in gds-api-adapters, for example?