Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button colour #2162

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix button colour #2162

merged 1 commit into from
Jun 29, 2021

Conversation

chris-gds
Copy link

@chris-gds chris-gds commented Jun 29, 2021

What

Fix to resolve buttons text colours on buttons
https://www.gov.uk/government/organisations/department-for-work-pensions/about/accessible-documents-policy

Why

Button text colours are being overwritten due to the styles applying department branding, this is an WCAG fails as the colour contrast makes this text unreadable therefore impact low vision and blind users.

Visuals

image

Anything else

As part of an on-going Epic corporate information templates will be updated entirely so this will act as a temporally fix until this work is complete

-  Fix to resolve buttons text colours are being overwritten.

/government/organisations/department-for-work-pensions/about/accessible-documents-policy
@chris-gds chris-gds requested a review from maxgds June 29, 2021 11:02
@bevanloon bevanloon temporarily deployed to government-f-fix-button-dfv89g June 29, 2021 11:03 Inactive
@maxgds
Copy link
Contributor

maxgds commented Jun 29, 2021

Looks good to me, but I just realised you still have it in draft mode. Let me know if it wants merging.

@chris-gds chris-gds marked this pull request as ready for review June 29, 2021 13:04
@chris-gds
Copy link
Author

chris-gds commented Jun 29, 2021

@maxgds maxgds merged commit 436ff9e into main Jun 29, 2021
@maxgds maxgds deleted the fix-button-colour branch June 29, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants