Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AB Test for Explore Super Menu Navigation #2156

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Conversation

chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Jun 22, 2021

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Shows users in B variant of AB test the new Explore Super Menu header.

Static has a new header that the GOV.UK Explore team want to AB test as part of their beta.
alphagov/static#2515

Trello https://trello.com/c/LUhrajXF/323-prepare-the-new-menu-a-b-test-for-sections-of-govuk

Why

We are slowly rolling out to users a redesigned header.

Visual changes

Screen.Recording.2021-06-22.at.22.33.32.mov
Screen.Recording.2021-06-29.at.6.18.59.pm.mov

@bevanloon bevanloon temporarily deployed to government-f-ab-test-he-mziiaf June 22, 2021 20:23 Inactive
@bevanloon bevanloon temporarily deployed to government-f-ab-test-he-mziiaf June 22, 2021 21:22 Inactive
@bevanloon bevanloon temporarily deployed to government-f-ab-test-he-mziiaf June 22, 2021 21:28 Inactive
@chao-xian chao-xian changed the title WIP Add AB Test for Explore Super Menu Navigation Jun 22, 2021
@bevanloon bevanloon temporarily deployed to government-f-ab-test-he-mziiaf June 22, 2021 21:51 Inactive
@bevanloon bevanloon temporarily deployed to government-f-ab-test-he-mziiaf June 22, 2021 21:59 Inactive
@chao-xian chao-xian marked this pull request as ready for review June 29, 2021 17:20
For the ContentItemsController to allow views to display a different template from Static that includes the new header if users are in the B variant.
@chao-xian chao-xian force-pushed the ab-test-header branch 2 times, most recently from 003bb45 to 53fc733 Compare July 5, 2021 11:54
@chao-xian chao-xian requested a review from alex-ju July 8, 2021 14:58
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a shame that you had to repeat the analytics_meta_tag in each partial. In the future we may find a way to DRY the content_items templates to share some code.

🆎

@chao-xian
Copy link
Contributor Author

I thought I could't use the application.html.erb layout but it turns out I can!

For users who are in the B variant of the AB Test, they get a template from Static that has the new Explore Super-menu Navigation.
@chao-xian chao-xian merged commit a3180e4 into main Jul 15, 2021
@chao-xian chao-xian deleted the ab-test-header branch July 15, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants