Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brexit child taxon descriptions #2144

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Brexit child taxon descriptions #2144

merged 6 commits into from
Jun 15, 2021

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Jun 14, 2021

What

No visual changes in this PR, I'm just amending the language we use in the code base to keep it in line with the terminology being used more widely in the team, and to make a few minor refactors before we get too far along.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 14, 2021 11:30 Inactive
@hannako hannako force-pushed the brexit_descriptions branch from 361f13c to 5031ea7 Compare June 14, 2021 11:35
@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 14, 2021 11:35 Inactive
@hannako hannako force-pushed the brexit_descriptions branch from 5031ea7 to 7ef5c50 Compare June 14, 2021 11:53
@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 14, 2021 11:53 Inactive
@hannako hannako force-pushed the brexit_descriptions branch from 7ef5c50 to 83da5de Compare June 14, 2021 11:56
@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 14, 2021 11:57 Inactive
@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 14, 2021 14:37 Inactive
sihugh
sihugh approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but nice gardening 👍

app/presenters/content_item/brexit_taxons.rb Outdated Show resolved Hide resolved
hannako added 6 commits June 15, 2021 10:08
@hannako
Improve structure of the brexit link hash
b61e519 
We are using the brexit_link hash to provide data to the frontend for different
sections of the page. So have given the hash some nesting to reflect that.
@hannako
Remove reference to hub pages
6389e8a 
UCD and analytics colleagues are refering to child taxon pages rather than
hub pages. Better if we all use the same language, so amending now.
@hannako
Rename partial to reflect that it contains sections (heading plus links)
17de241
@hannako
Rename brexit_link --> brexit_child_taxon
4bd374f 
Using the term brexit_link was a bit confusing now there is a partial
and a parser to build links for these brexit pages.
@hannako
Update url in breadcrumbs
3ae3a1f
@hannako
remove namespacing
32d1e9a
@hannako hannako force-pushed the brexit_descriptions branch from 007729a to 32d1e9a Compare June 15, 2021 09:38
@bevanloon bevanloon temporarily deployed to government-f-brexit-des-rtdw07 June 15, 2021 09:38 Inactive
@hannako hannako merged commit 4be7e54 into main Jun 15, 2021
@hannako hannako deleted the brexit_descriptions branch June 15, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihugh sihugh sihugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannako @sihugh @bevanloon